script/lint

#!/bin/bash -ex

# Ensure the repository is clean after code generation.
./script/generate
test -z "$(git status --porcelain)"

# Still clean after formatting.
./script/fmt
test -z "$(git status --porcelain)"

# And it's still clean after asmfmt.
# Note: we want to confirm we agree with asmfmt without actually depending on it.
find . -name '*.s' | xargs asmfmt -w
test -z "$(git status --porcelain)"

# Run suite of golangci-lint checks.
# (Provide examples directory explicitly since it is skipped by default.)
golangci-lint run ./... ./examples/...

# Check asm declarations.
go vet -vettool=$(which asmvet) ./...

# Custom linters.
./script/linter/pkgdoc
start a lint script 2018-11-30 21:47:10 -08:00			`#!/bin/bash -ex`

			`# Ensure the repository is clean after code generation.`
			`./script/generate`
			`test -z "$(git status --porcelain)"`
enable some more linters 2018-12-05 00:49:12 -08:00
all: formatting (#93) Enforce stricter formatting and import grouping with gofumports. 2019-07-30 18:40:47 -07:00			`# Still clean after formatting.`
			`./script/fmt`
			`test -z "$(git status --porcelain)"`

lint: ensure conformity with asmfmt Run asmfmt suring linting and confirm git repository isn't dirty. This introduces a developer tools dependency on asmfmt, but not a runtime dependency. Updates #8 2019-01-10 21:31:04 -08:00			`# And it's still clean after asmfmt.`
			`# Note: we want to confirm we agree with asmfmt without actually depending on it.`
			`find . -name '*.s' \| xargs asmfmt -w`
			`test -z "$(git status --porcelain)"`

enable some more linters 2018-12-05 00:49:12 -08:00			`# Run suite of golangci-lint checks.`
lint: fix issues in examples (#49) 2019-01-13 10:12:52 -08:00			`# (Provide examples directory explicitly since it is skipped by default.)`
			`golangci-lint run ./... ./examples/...`
lint: run asmdecl Updates #24 2019-01-13 12:02:06 -08:00
			`# Check asm declarations.`
pass: ensure frame pointer register is saved (#174) Currently `avo` uses `BP` as a standard general-purpose register. However, `BP` is used for the frame pointer and should be callee-save. Under some circumstances, the Go assembler will do this automatically, but not always. At the moment `avo` can produce code that clobbers the `BP` register. Since Go 1.16 this code will also fail a new `go vet` check. This PR provides a (currently sub-optimal) fix for the issue. It introduces an `EnsureBasePointerCalleeSaved` pass which will check if the base pointer is written to by a function, and if so will artificially ensure that the function has a non-zero frame size. This will trigger the Go assembler to automatically save and restore the BP register. In addition, we update the `asmdecl` tool to `asmvet`, which includes the `framepointer` vet check. Updates #156 2021-04-18 18:37:56 -07:00			`go vet -vettool=$(which asmvet) ./...`
lint: linter for package docstrings (#59) Fixes #38 2019-01-22 21:14:59 -08:00
			`# Custom linters.`
			`./script/linter/pkgdoc`