From 56c962b9aa845aec1195edb4525abb77b68a6f28 Mon Sep 17 00:00:00 2001 From: Michael McLoughlin Date: Wed, 9 Jan 2019 22:31:14 -0800 Subject: [PATCH] lint: switch to linter blacklist --- .golangci.yml | 29 +++++++++-------------------- internal/stack/stack.go | 4 ++-- 2 files changed, 11 insertions(+), 22 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 31ba8f9..76c7c4a 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -1,24 +1,13 @@ linters: - enable-all: false - enable: - - golint - - gosimple - - misspell - - gocyclo - - gofmt - - structcheck - - varcheck - - ineffassign - - typecheck - - megacheck - - deadcode - - govet - - errcheck - - goimports - - depguard - - goconst - - unconvert - - gocritic + enable-all: true + disable: + - maligned + - lll + - gosec + - prealloc + - unparam + - gochecknoglobals + - gochecknoinits linters-settings: depguard: diff --git a/internal/stack/stack.go b/internal/stack/stack.go index 8445ba5..1d327d9 100644 --- a/internal/stack/stack.go +++ b/internal/stack/stack.go @@ -35,9 +35,9 @@ func Match(skip int, predicate func(runtime.Frame) bool) *runtime.Frame { i, n := skip+1, 16 for { fs := Frames(i, n) - for _, f := range fs { + for j, f := range fs { if predicate(f) { - return &f + return &fs[j] } } if len(fs) < n {