From b01bfffcddd2ecf72dac3f040c272bdd8e3d9f3f Mon Sep 17 00:00:00 2001 From: Michael McLoughlin Date: Sat, 14 Jan 2023 16:12:42 -0800 Subject: [PATCH] internal/opcodesextra: minor comment tweaks (#366) --- internal/opcodesextra/bitalg.go | 2 +- internal/opcodesextra/vbmi2.go | 8 ++++++++ internal/opcodesextra/vpclmulqdq.go | 3 +-- internal/opcodesextra/vpopcntdq.go | 3 +-- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/internal/opcodesextra/bitalg.go b/internal/opcodesextra/bitalg.go index 999de20..cf550f7 100644 --- a/internal/opcodesextra/bitalg.go +++ b/internal/opcodesextra/bitalg.go @@ -2,7 +2,7 @@ package opcodesextra import "github.com/mmcloughlin/avo/internal/inst" -// bitalg is the AVX-512 Bit Algorithms instruction set. +// bitalg is the "Bit Algorithms" instruction set. var bitalg = []*inst.Instruction{ // Reference: https://github.com/golang/go/blob/go1.19.3/src/cmd/internal/obj/x86/avx_optabs.go#L3904-L3908 // diff --git a/internal/opcodesextra/vbmi2.go b/internal/opcodesextra/vbmi2.go index b73637c..2d7cf19 100644 --- a/internal/opcodesextra/vbmi2.go +++ b/internal/opcodesextra/vbmi2.go @@ -185,6 +185,8 @@ var vbmi2 = []*inst.Instruction{ // VPCOMPRESSB and VPCOMPRESSW forms. // +// See: https://www.felixcloutier.com/x86/vpcompressb:vcompressw +// // Reference: https://github.com/golang/go/blob/go1.19.3/src/cmd/internal/obj/x86/avx_optabs.go#L240-L247 // // var _yvcompresspd = []ytab{ @@ -254,6 +256,8 @@ var vpcompressb = inst.Forms{ // VPEXPANDB and VPEXPANDW forms. // +// See: https://www.felixcloutier.com/x86/vpexpandb:vpexpandw +// // Reference: https://github.com/golang/go/blob/go1.19.3/src/cmd/internal/obj/x86/avx_optabs.go#L376-L383 // // var _yvexpandpd = []ytab{ @@ -268,6 +272,8 @@ var vpexpandb = _yvexpandpd("AVX512VBMI2", "") // VPSH{L,R}D{W,D,Q} forms. // +// See: https://www.felixcloutier.com/x86/vpshld https://www.felixcloutier.com/x86/vpshrd +// // Reference: https://github.com/golang/go/blob/go1.19.3/src/cmd/internal/obj/x86/avx_optabs.go#L128-L135 // // var _yvalignd = []ytab{ @@ -354,6 +360,8 @@ func vpshld(bcst string) inst.Forms { // VPSH{L,R}DV{W,D,Q} forms. // +// See: https://www.felixcloutier.com/x86/vpshldv https://www.felixcloutier.com/x86/vpshrdv +// // Reference: https://github.com/golang/go/blob/go1.19.3/src/cmd/internal/obj/x86/avx_optabs.go#L148-L155 // // var _yvblendmpd = []ytab{ diff --git a/internal/opcodesextra/vpclmulqdq.go b/internal/opcodesextra/vpclmulqdq.go index 03aec6f..166b209 100644 --- a/internal/opcodesextra/vpclmulqdq.go +++ b/internal/opcodesextra/vpclmulqdq.go @@ -2,8 +2,7 @@ package opcodesextra import "github.com/mmcloughlin/avo/internal/inst" -// vpclmulqdq adds VEX and EVEX encoded versions of the PCLMULQDQ carry-less -// quadword multiplication instruction. +// vpclmulqdq is the "Vector Carry-less Multiplication" instruction set. var vpclmulqdq = []*inst.Instruction{ // Reference: https://github.com/golang/go/blob/go1.19.3/src/cmd/internal/obj/x86/avx_optabs.go#L2911-L2917 // diff --git a/internal/opcodesextra/vpopcntdq.go b/internal/opcodesextra/vpopcntdq.go index ca3b5d5..c3ea4b3 100644 --- a/internal/opcodesextra/vpopcntdq.go +++ b/internal/opcodesextra/vpopcntdq.go @@ -2,8 +2,7 @@ package opcodesextra import "github.com/mmcloughlin/avo/internal/inst" -// vpopcntdq is the VPOPCNTDQ instruction set, providing packed population count -// for double and quadword integers. +// vpopcntdq is the "Vector Population Count" instruction set. var vpopcntdq = []*inst.Instruction{ // Reference: https://github.com/golang/go/blob/go1.19.3/src/cmd/internal/obj/x86/avx_optabs.go#L3741-L3750 //