code/avo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pass: ensure frame pointer register is saved (#174)

Browse Source 
Currently `avo` uses `BP` as a standard general-purpose register. However, `BP` is used for the frame pointer and should be callee-save. Under some circumstances, the Go assembler will do this automatically, but not always. At the moment `avo` can produce code that clobbers the `BP` register. Since Go 1.16 this code will also fail a new `go vet` check.

This PR provides a (currently sub-optimal) fix for the issue. It introduces an `EnsureBasePointerCalleeSaved` pass which will check if the base pointer is written to by a function, and if so will artificially ensure that the function has a non-zero frame size. This will trigger the Go assembler to automatically save and restore the BP register.

In addition, we update the `asmdecl` tool to `asmvet`, which includes the `framepointer` vet check.

Updates #156
This commit is contained in:
Michael McLoughlin
2021-04-18 18:37:56 -07:00
committed by GitHub
parent 4592e16ebb
commit f295bde84c
16 changed files with 154 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
script/bootstrap
View File

@@ -1,7 +1,7 @@
#!/bin/bash -ex
# Standalone version of the asmdecl analysis tool.
go install ./internal/cmd/asmdecl
# Standalone version of the assembly checks in go vet.
go install ./internal/cmd/asmvet
# Install golangci-lint
golangci_lint_version='v1.23.6'